487942 - Remove cursor: -moz-alias | -moz-cell | -moz-context-menu | -moz-copy | -moz-spinning

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[j.j.]

Drop support for cursor values
-moz-alias | -moz-cell | -moz-context-menu | -moz-copy| -moz-spinning

The un-prefixed values are supported since Gecko 1.8, "progress" as replacement for "-moz-spinning" since 1.7.
Would be consistent to remove this in 1.9.2 like -moz-outline* (bug 458588).

Daniel, fixing those bugs seems your hobby, so I CCd you.

Comment 1

[Daniel.S]

Attachment: remove: -moz-cell alias [Checkin: Comment 11]

This patch removes the -moz-cell property which is unused in the tree. It's a CSS 3 value though, but since we implement cursor: cell; already...

@j.j.:
Sadly, in this case I'm not a great help, except for -moz-cell, all other values seem to be dependent on some GTK2 Widget code, see http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsGtkCursors.h

I don't know that code and I can't test changes there. However, all five values are unused and could be removed at any time. In fact, -moz-spinning should be removed since progress is a CSS 2.1 keyword.

Comment 2

[j.j.]

(In reply to comment #1)
> It's a CSS 3 value though, but since we implement cursor: cell; already...

All values are from "CSS3 Basic User Interface Module", which is in CR state since 2004.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 372230 [details] [diff] [review]
remove: -moz-cell alias
[Checkin: Comment 11]

r+sr=dbaron.

(While we're here, we should probably add the css3 values that we support, and the -moz- values that we're keeping, to layout/style/test/property_database.js.)

Comment 4

[j.j.]

Attachment: CSS cursor testcase

Includes CSS 2.1, CSS 3, -moz-, -webkit- and IE cursors.

Comment 5

[j.j.]

(In reply to comment #3)

> (While we're here, we should probably add the css3 values that we support, and

AFAIK we support all CSS3 values (see testcase), but

- "no-drop"      has bug 275173 on Windows
- "all-scroll"   has bug 275175 on Windows
- "context-menu" not on Windows. Is there any reason why web applications shoudn't use this cursor on windows?

Comment 6

[j.j.]

(In reply to comment #5)
> - "all-scroll"   has bug 275175 on Windows

Sorry, should read:
 - "all-scroll"   has bug 275174 on Windows

Comment 7

[Daniel.S]

Attachment: property_database.js update [Checkin: Comment 12]

I added the keywords in the same order used in nsCSSProps.cpp

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 373460 [details] [diff] [review]
property_database.js update
[Checkin: Comment 12]

r+sr=dbaron assuming you've run the tests in layout/style and they still pass :-)

Comment 9

[Daniel.S]

(In reply to comment #8)
> (From update of attachment 373460 [details] [diff] [review])
> r+sr=dbaron assuming you've run the tests in layout/style and they still pass
> :-)

All right, homework done - tests passed :-)

Comment 10

[j.j.]

Attachment: CSS cursor testcase

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 372230 [details] [diff] [review]
remove: -moz-cell alias
[Checkin: Comment 11]


http://hg.mozilla.org/mozilla-central/rev/19192988b672

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 373460 [details] [diff] [review]
property_database.js update
[Checkin: Comment 12]


http://hg.mozilla.org/mozilla-central/rev/bafeec3a45c8

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is not fixed yet; only one of the values has been removed.

I'd also note that it would be helpful to have clearer checkin comments; it's better not to use the whole title of the bug, but just to say what that particular patch is doing.  That said, it would be helpful if the patch author provided those at the start of the patch.

Comment 14

[Takeshi Kurosawa :takenspc]

Attachment: Remove -moz-alias, -moz-context-menu, -moz-copy and -moz-spinning

Remove -moz-alias, -moz-cell, -moz-context-menu, -moz-copy and -moz-spinning.
Including tests update.

# http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsGtkCursors.h is not related this bug.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 403702 [details] [diff] [review]
Remove -moz-alias, -moz-context-menu, -moz-copy and -moz-spinning 

r=dbaron.  Sorry for the delay

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/374169762764

Thanks for the patch.